Skip to content

Commit

Permalink
Fix spurious compile error
Browse files Browse the repository at this point in the history
From time to time, I would get this error:

[...]
sed: -e expression #8, char 41: Unterminated `s' command
make: *** [git-add--interactive] Error 1

Turns out that the function WriteMakefile() called in Makefile.PL
outputs the message "Writing perl.mak for Git" to stdout! Thus,
the output of "make -C perl -s --no-print-directory instlibdir"
would be prefixed by that message whenever Makefile.PL was newer
than perl.mak.

This is fixed by redirecting stdout to stderr in Makefile.PL.

Signed-off-by: Johannes E. Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Johannes Schindelin authored and Junio C Hamano committed Jan 16, 2007
1 parent a9877f8 commit 8bef620
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions perl/Makefile.PL
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ if ($@) {
my %extra;
$extra{DESTDIR} = $ENV{DESTDIR} if $ENV{DESTDIR};

# redirect stdout, otherwise the message "Writing perl.mak for Git"
# disrupts the output for the target 'instlibdir'
open STDOUT, ">&STDERR";

WriteMakefile(
NAME => 'Git',
VERSION_FROM => 'Git.pm',
Expand Down

0 comments on commit 8bef620

Please sign in to comment.