Skip to content

Commit

Permalink
imap-send: cleanup execl() call to use NULL sentinel instead of 0
Browse files Browse the repository at this point in the history
Some versions of gcc check that calls to the exec() family have the proper
sentinel for variadic calls. This should be (char *) NULL according to the
man page. Although for all other purposes the 0 is equivalent, gcc
nevertheless does emit a warning for 0 and not for NULL. This also makes the
usage consistent throughout git.

The whitespace in function calls throughout imap-send.c has its own style,
so I left it that way.

Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Marco Roeland authored and Junio C Hamano committed Mar 11, 2006
1 parent be767c9 commit 8e7f903
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion imap-send.c
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,7 @@ imap_open_store( imap_server_conf_t *srvc )
_exit( 127 );
close( a[0] );
close( a[1] );
execl( "/bin/sh", "sh", "-c", srvc->tunnel, 0 );
execl( "/bin/sh", "sh", "-c", srvc->tunnel, NULL );
_exit( 127 );
}

Expand Down

0 comments on commit 8e7f903

Please sign in to comment.