Skip to content

Commit

Permalink
t1301-shared-repo.sh: don't let a default ACL interfere with the test
Browse files Browse the repository at this point in the history
This test creates files with several different umasks and expects their
permissions to be initialized according to the umask, so a default ACL on the
trash directory (which overrides the umask for files created in that directory)
causes the test to fail.  To avoid that, remove the default ACL if possible with
setfacl(1).

Signed-off-by: Matt McCutchen <matt@mattmccutchen.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Matt McCutchen authored and Junio C Hamano committed Oct 17, 2008
1 parent 5782566 commit 8ed0a74
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions t/t1301-shared-repo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ test_description='Test shared repository initialization'

. ./test-lib.sh

# Remove a default ACL from the test dir if possible.
setfacl -k . 2>/dev/null

# User must have read permissions to the repo -> failure on --shared=0400
test_expect_success 'shared = 0400 (faulty permission u-w)' '
mkdir sub && (
Expand Down

0 comments on commit 8ed0a74

Please sign in to comment.