Skip to content

Commit

Permalink
git-remote-mediawiki: change the name of a variable
Browse files Browse the repository at this point in the history
Local variable $url has the same name as a global variable. Changing the name
of the local variable prevents future possible misunderstanding.

Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr>
Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Célestin Matte authored and Junio C Hamano committed Jun 14, 2013
1 parent 8a43b36 commit 8f04f7d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions contrib/mw-to-git/git-remote-mediawiki.perl
Original file line number Diff line number Diff line change
Expand Up @@ -454,14 +454,14 @@ sub get_mw_mediafile_for_page_revision {
}

sub download_mw_mediafile {
my $url = shift;
my $download_url = shift;

my $response = $mediawiki->{ua}->get($url);
my $response = $mediawiki->{ua}->get($download_url);
if ($response->code == 200) {
return $response->decoded_content;
} else {
print STDERR "Error downloading mediafile from :\n";
print STDERR "URL: $url\n";
print STDERR "URL: $download_url\n";
print STDERR "Server response: " . $response->code . " " . $response->message . "\n";
exit 1;
}
Expand Down

0 comments on commit 8f04f7d

Please sign in to comment.