Skip to content

Commit

Permalink
repo-config: deconvolute logics
Browse files Browse the repository at this point in the history
It was rightly noticed that the logic is quite convoluted. Fix that.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Johannes Schindelin authored and Junio C Hamano committed May 3, 2006
1 parent e098c6f commit 8f5ff31
Showing 1 changed file with 26 additions and 24 deletions.
50 changes: 26 additions & 24 deletions repo-config.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,36 +27,38 @@ static int show_config(const char* key_, const char* value_)
{
char value[256];
const char *vptr = value;
int dup_error = 0;

if (value_ == NULL)
value_ = "";

if ((use_key_regexp || !strcmp(key_, key)) &&
(!use_key_regexp ||
!regexec(key_regexp, key_, 0, NULL, 0)) &&
(regexp == NULL ||
if (!use_key_regexp && strcmp(key_, key))
return 0;
if (use_key_regexp && regexec(key_regexp, key_, 0, NULL, 0))
return 0;
if (regexp != NULL &&
(do_not_match ^
!regexec(regexp, value_, 0, NULL, 0)))) {
int dup_error = 0;
if (show_keys)
printf("%s ", key_);
if (seen && !do_all)
dup_error = 1;
if (type == T_INT)
sprintf(value, "%d", git_config_int(key_, value_));
else if (type == T_BOOL)
sprintf(value, "%s", git_config_bool(key_, value_)
? "true" : "false");
else
vptr = value_;
seen++;
if (dup_error) {
error("More than one value for the key %s: %s",
key_, vptr);
}
else
printf("%s\n", vptr);
regexec(regexp, value_, 0, NULL, 0)))
return 0;

if (show_keys)
printf("%s ", key_);
if (seen && !do_all)
dup_error = 1;
if (type == T_INT)
sprintf(value, "%d", git_config_int(key_, value_));
else if (type == T_BOOL)
vptr = git_config_bool(key_, value_) ? "true" : "false";
else
vptr = value_;
seen++;
if (dup_error) {
error("More than one value for the key %s: %s",
key_, vptr);
}
else
printf("%s\n", vptr);

return 0;
}

Expand Down

0 comments on commit 8f5ff31

Please sign in to comment.