Skip to content

Commit

Permalink
Allow core.askpass to override SSH_ASKPASS.
Browse files Browse the repository at this point in the history
Modify handling of the 'core.askpass' option so that it has the same effect as
GIT_ASKPASS also if SSH_ASKPASS is set.

Signed-off-by: Knut Franke <k.franke@science-computing.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Knut Franke authored and Junio C Hamano committed Aug 31, 2010
1 parent d3e7da8 commit 90e87b0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 2 additions & 1 deletion connect.c
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,8 @@ char *git_getpass(const char *prompt)
askpass = getenv("GIT_ASKPASS");
if (!askpass)
askpass = askpass_program;

if (!askpass)
askpass = getenv("SSH_ASKPASS");
if (!askpass || !(*askpass))
return getpass(prompt);

Expand Down
3 changes: 0 additions & 3 deletions git.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ static int handle_options(const char ***argv, int *argc, int *envchanged)
{
int handled = 0;

if (!getenv("GIT_ASKPASS") && getenv("SSH_ASKPASS"))
setenv("GIT_ASKPASS", getenv("SSH_ASKPASS"), 1);

while (*argc > 0) {
const char *cmd = (*argv)[0];
if (cmd[0] != '-')
Expand Down

0 comments on commit 90e87b0

Please sign in to comment.