Skip to content

Commit

Permalink
show_patch_diff(): remove a call to fstat()
Browse files Browse the repository at this point in the history
Currently inside show_patch_diff() we have an fstat() call after an
ok lstat() call.  Since before the call to fstat() we have already
tested for the link case with S_ISLNK(), the fstat() can be removed.

Signed-off-by: Kjetil Barvik <barvik@broadpark.no>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Kjetil Barvik authored and Junio C Hamano committed Feb 10, 2009
1 parent e4c7292 commit 91fcbcb
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions combine-diff.c
Original file line number Diff line number Diff line change
Expand Up @@ -713,9 +713,7 @@ static void show_patch_diff(struct combine_diff_path *elem, int num_parent,
result_size = buf.len;
result = strbuf_detach(&buf, NULL);
elem->mode = canon_mode(st.st_mode);
}
else if (0 <= (fd = open(elem->path, O_RDONLY)) &&
!fstat(fd, &st)) {
} else if (0 <= (fd = open(elem->path, O_RDONLY))) {
size_t len = xsize_t(st.st_size);
ssize_t done;
int is_file, i;
Expand Down

0 comments on commit 91fcbcb

Please sign in to comment.