Skip to content

Commit

Permalink
Don't modify CREDITS-FILE if it hasn't changed.
Browse files Browse the repository at this point in the history
We should always avoid rewriting a built file during `make install`
if nothing has changed since `make all`.  This is to help support
the typical installation process of compiling a package as yourself,
then installing it as root.

Forcing CREDITS-FILE to be always be rebuilt in the Makefile means
that CREDITS-GEN needs to check for a change and only update
CREDITS-FILE if the file content actually differs.  After all,
content is king in Git.

Signed-off-by: Junio C Hamano <junkio@cox.net>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
  • Loading branch information
Junio C Hamano authored and Shawn O. Pearce committed Feb 25, 2007
1 parent 9811937 commit 92446ab
Showing 1 changed file with 19 additions and 6 deletions.
25 changes: 19 additions & 6 deletions CREDITS-GEN
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ tree_search ()
generate_credits ()
{
tip=$1 &&
rm -f $CF &&
git shortlog -n -s $tip | sed 's/: .*$//' >$CF || exit
rm -f "$2" &&
git shortlog -n -s $tip | sed 's/: .*$//' >"$2" || exit
}

# Always use the tarball credits file if found, just
Expand All @@ -36,23 +36,36 @@ generate_credits ()
# that fact.
#

credits_tmp=/var/tmp/gitgui-credits-$$
trap 'rm -f "$credits_tmp"' 0

orig="$credits_tmp"

if test -f credits
then
rm -f $CF &&
cp credits $CF || exit
orig=credits
elif prefix="$(git rev-parse --show-prefix 2>/dev/null)" &&
test -n "$prefix" &&
head=$(git rev-list --max-count=1 HEAD -- . 2>/dev/null) &&
tree=$(git rev-parse --verify "HEAD:$prefix" 2>/dev/null) &&
tip=$(tree_search $head $tree) &&
test -n "$tip"
then
generate_credits $tip || exit
generate_credits $tip "$orig" || exit
elif tip="$(git rev-parse --verify HEAD 2>/dev/null)" &&
test -n "$tip"
then
generate_credits $tip || exit
generate_credits $tip "$orig" || exit
else
echo "error: Cannot locate authorship information." >&2
exit 1
fi

if test -f "$orig" && cmp -s "$orig" "$CF"
then
: noop
else
rm -f "$CF" &&
cat "$orig" >"$CF"
fi

0 comments on commit 92446ab

Please sign in to comment.