Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
unimplemented.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
	perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg'  "${_f}"
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Elia Pinto authored and Junio C Hamano committed Dec 27, 2015
1 parent 21c6f98 commit 92bea95
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion unimplemented.sh
@@ -1,4 +1,4 @@
#!/bin/sh

echo >&2 "fatal: git was built without support for `basename $0` (@@REASON@@)."
echo >&2 "fatal: git was built without support for $(basename $0) (@@REASON@@)."
exit 128

0 comments on commit 92bea95

Please sign in to comment.