Skip to content

Commit

Permalink
stash: fix false positive in the invalid ref test.
Browse files Browse the repository at this point in the history
Jeff King reported a problem with git stash apply incorrectly
applying an invalid stash reference.

There is an existing test that should have caught this, but
the test itself was broken, resulting in a false positive.

Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jon Seymour authored and Junio C Hamano committed Apr 6, 2011
1 parent 59d418f commit 9355fc9
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions t/t3903-stash.sh
Original file line number Diff line number Diff line change
Expand Up @@ -543,11 +543,11 @@ test_expect_success 'invalid ref of the form stash@{n}, n >= N' '
echo bar6 > file2 &&
git add file2 &&
git stash &&
test_must_fail git drop stash@{1} &&
test_must_fail git pop stash@{1} &&
test_must_fail git apply stash@{1} &&
test_must_fail git show stash@{1} &&
test_must_fail git branch tmp stash@{1} &&
test_must_fail git stash drop stash@{1} &&
test_must_fail git stash pop stash@{1} &&
test_must_fail git stash apply stash@{1} &&
test_must_fail git stash show stash@{1} &&
test_must_fail git stash branch tmp stash@{1} &&
git stash drop
'

Expand Down

0 comments on commit 9355fc9

Please sign in to comment.