Skip to content

Commit

Permalink
git-gui: Fix the search bar destruction handler.
Browse files Browse the repository at this point in the history
Since delete_this is an ordinary function, it
should not be passed to cb; otherwise it produces
errors when blame windows are closed. Unfortunately,
it is not noticeable when blame is shown in the
master window, so I missed this bug.

Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
  • Loading branch information
Alexander Gavrilov authored and Shawn O. Pearce committed Nov 16, 2008
1 parent bd45bd9 commit 9419307
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/search.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ constructor new {i_w i_text args} {

trace add variable searchstring write [cb _incrsearch_cb]

bind $w <Destroy> [cb delete_this]
bind $w <Destroy> [list delete_this $this]
return $this
}

Expand Down

0 comments on commit 9419307

Please sign in to comment.