Skip to content

Commit

Permalink
Pass CVSps generated A U Thor <author@domain.xz> intact.
Browse files Browse the repository at this point in the history
Alexey Nezhdanov updated CVSps to generate author-name and
author-email information in its output.

If the input looks like it has that already properly formatted,
use that without our own munging.

Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Junio C Hamano committed Oct 2, 2005
1 parent 37f15d5 commit 94c2334
Showing 1 changed file with 11 additions and 7 deletions.
18 changes: 11 additions & 7 deletions git-cvsimport.perl
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ ($$)

my $state = 0;

my($patchset,$date,$author,$branch,$ancestor,$tag,$logmsg);
my($patchset,$date,$author_name,$author_email,$branch,$ancestor,$tag,$logmsg);
my(@old,@new);
my $commit = sub {
my $pid;
Expand Down Expand Up @@ -591,11 +591,11 @@ ($$)
}

exec("env",
"GIT_AUTHOR_NAME=$author",
"GIT_AUTHOR_EMAIL=$author",
"GIT_AUTHOR_NAME=$author_name",
"GIT_AUTHOR_EMAIL=$author_email",
"GIT_AUTHOR_DATE=".strftime("+0000 %Y-%m-%d %H:%M:%S",gmtime($date)),
"GIT_COMMITTER_NAME=$author",
"GIT_COMMITTER_EMAIL=$author",
"GIT_COMMITTER_NAME=$author_name",
"GIT_COMMITTER_EMAIL=$author_email",
"GIT_COMMITTER_DATE=".strftime("+0000 %Y-%m-%d %H:%M:%S",gmtime($date)),
"git-commit-tree", $tree,@par);
die "Cannot exec git-commit-tree: $!\n";
Expand Down Expand Up @@ -638,7 +638,7 @@ ($$)
print $out "object $cid\n".
"type commit\n".
"tag $xtag\n".
"tagger $author <$author>\n"
"tagger $author_name <$author_email>\n"
or die "Cannot create tag object $xtag: $!\n";
close($out)
or die "Cannot create tag object $xtag: $!\n";
Expand Down Expand Up @@ -683,7 +683,11 @@ ($$)
$state=3;
} elsif($state == 3 and s/^Author:\s+//) {
s/\s+$//;
$author = $_;
if (/^(.*?)\s+<(.*)>/) {
($author_name, $author_email) = ($1, $2);
} else {
$author_name = $author_email = $_;
}
$state = 4;
} elsif($state == 4 and s/^Branch:\s+//) {
s/\s+$//;
Expand Down

0 comments on commit 94c2334

Please sign in to comment.