Skip to content

Commit

Permalink
Revert "Git.pm: Introduce fast get_object() method"
Browse files Browse the repository at this point in the history
This reverts commit 3c479c3.
  • Loading branch information
Junio C Hamano committed Sep 3, 2006
1 parent 3c2f588 commit 9594b32
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 42 deletions.
18 changes: 0 additions & 18 deletions perl/Git.pm
Original file line number Diff line number Diff line change
Expand Up @@ -572,24 +572,6 @@ sub ident_person {
}


=item get_object ( TYPE, SHA1 )
Return contents of the given object in a scalar string. If the object has
not been found, undef is returned; however, do not rely on this! Currently,
if you use multiple repositories at once, get_object() on one repository
_might_ return the object even though it exists only in another repository.
(But do not rely on this behaviour either.)
The method must be called on a repository instance.
Implementation of this method is very fast; no external command calls
are involved. That's why it is broken, too. ;-)
=cut

# Implemented in Git.xs.


=item hash_object ( TYPE, FILENAME )
=item hash_object ( TYPE, FILEHANDLE )
Expand Down
24 changes: 0 additions & 24 deletions perl/Git.xs
Original file line number Diff line number Diff line change
Expand Up @@ -111,30 +111,6 @@ CODE:
free((char **) argv);
}


SV *
xs_get_object(type, id)
char *type;
char *id;
CODE:
{
unsigned char sha1[20];
unsigned long size;
void *buf;

if (strlen(id) != 40 || get_sha1_hex(id, sha1) < 0)
XSRETURN_UNDEF;

buf = read_sha1_file(sha1, type, &size);
if (!buf)
XSRETURN_UNDEF;
RETVAL = newSVpvn(buf, size);
free(buf);
}
OUTPUT:
RETVAL


char *
xs_hash_object_pipe(type, fd)
char *type;
Expand Down

0 comments on commit 9594b32

Please sign in to comment.