Skip to content

Commit

Permalink
Make write_sha1_file_prepare() void
Browse files Browse the repository at this point in the history
Move file name generation from write_sha1_file_prepare() to the one
caller that cares and make it a void function.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Rene Scharfe authored and Junio C Hamano committed Oct 15, 2006
1 parent 29f049a commit 972a915
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions sha1_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -1347,9 +1347,9 @@ void *read_object_with_reference(const unsigned char *sha1,
}
}

static char *write_sha1_file_prepare(void *buf, unsigned long len,
const char *type, unsigned char *sha1,
unsigned char *hdr, int *hdrlen)
static void write_sha1_file_prepare(void *buf, unsigned long len,
const char *type, unsigned char *sha1,
unsigned char *hdr, int *hdrlen)
{
SHA_CTX c;

Expand All @@ -1361,8 +1361,6 @@ static char *write_sha1_file_prepare(void *buf, unsigned long len,
SHA1_Update(&c, hdr, *hdrlen);
SHA1_Update(&c, buf, len);
SHA1_Final(sha1, &c);

return sha1_file_name(sha1);
}

/*
Expand Down Expand Up @@ -1521,7 +1519,8 @@ int write_sha1_file(void *buf, unsigned long len, const char *type, unsigned cha
/* Normally if we have it in the pack then we do not bother writing
* it out into .git/objects/??/?{38} file.
*/
filename = write_sha1_file_prepare(buf, len, type, sha1, hdr, &hdrlen);
write_sha1_file_prepare(buf, len, type, sha1, hdr, &hdrlen);
filename = sha1_file_name(sha1);
if (returnsha1)
hashcpy(returnsha1, sha1);
if (has_sha1_file(sha1))
Expand Down

0 comments on commit 972a915

Please sign in to comment.