Skip to content

Commit

Permalink
test-lib.sh - define and use GREP_STRIPS_CR
Browse files Browse the repository at this point in the history
Define a common macro for grep needing -U to allow tests to not need
to inquire of specific platforms needing this option. Change
t3032 and t5560 to use this rather than testing explicitly for mingw.
This fixes these two tests on Cygwin.

Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Mark Levedahl authored and Junio C Hamano committed Jul 18, 2013
1 parent f59bebb commit 97669ee
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion t/t3032-merge-recursive-options.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test_description='merge-recursive options
. ./test-lib.sh

test_have_prereq SED_STRIPS_CR && SED_OPTIONS=-b
test_have_prereq MINGW && export GREP_OPTIONS=-U
test_have_prereq GREP_STRIPS_CR && export GREP_OPTIONS=-U

test_expect_success 'setup' '
conflict_hunks () {
Expand Down
2 changes: 1 addition & 1 deletion t/t5560-http-backend-noserver.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ test_description='test git-http-backend-noserver'

HTTPD_DOCUMENT_ROOT_PATH="$TRASH_DIRECTORY"

test_have_prereq MINGW && export GREP_OPTIONS=-U
test_have_prereq GREP_STRIPS_CR && export GREP_OPTIONS=-U

run_backend() {
echo "$2" |
Expand Down
2 changes: 2 additions & 0 deletions t/test-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -668,13 +668,15 @@ case $(uname -s) in
test_set_prereq MINGW
test_set_prereq NOT_CYGWIN
test_set_prereq SED_STRIPS_CR
test_set_prereq GREP_STRIPS_CR
;;
*CYGWIN*)
test_set_prereq POSIXPERM
test_set_prereq EXECKEEPSPID
test_set_prereq NOT_MINGW
test_set_prereq CYGWIN
test_set_prereq SED_STRIPS_CR
test_set_prereq GREP_STRIPS_CR
;;
*)
test_set_prereq POSIXPERM
Expand Down

0 comments on commit 97669ee

Please sign in to comment.