Skip to content

Commit

Permalink
builtin/init-db.c: eliminate -Wformat warning on Solaris
Browse files Browse the repository at this point in the history
On Solaris systems we'd warn about an implicit cast of mode_t when we
printed things out with the %d format. We'd get this warning under GCC
4.6.0 with Solaris headers:

    builtin/init-db.c: In function ‘separate_git_dir’:
    builtin/init-db.c:354:4: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘mode_t’ [-Wformat]

We've been doing this ever since v1.7.4.1-296-gb57fb80. Just work
around this by adding an explicit cast.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Ævar Arnfjörð Bjarmason authored and Junio C Hamano committed Dec 21, 2011
1 parent 7b6c583 commit 97f261b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion builtin/init-db.c
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ static void separate_git_dir(const char *git_dir)
else if (S_ISDIR(st.st_mode))
src = git_link;
else
die(_("unable to handle file type %d"), st.st_mode);
die(_("unable to handle file type %d"), (int)st.st_mode);

if (rename(src, git_dir))
die_errno(_("unable to move %s to %s"), src, git_dir);
Expand Down

0 comments on commit 97f261b

Please sign in to comment.