Skip to content

Commit

Permalink
gitweb: Default to $hash_base or HEAD for $hash in "commit" and "comm…
Browse files Browse the repository at this point in the history
…itdiff"

Set $hash parameter to $hash_base || "HEAD" if it is not set (if it is
not true to be more exact). This allows [hand-edited] URLs with 'action'
"commit" or "commitdiff" but without 'hash' parameter.

If there is 'h' (hash) parameter provided, then gitweb tries
to use this. HEAD is used _only_ if nether hash, nor hash_base
are provided, i.e. for URL like below
  URL?p=project.git;a=commit
i.e. without neither 'h' nor 'hb'.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Jakub Narebski authored and Junio C Hamano committed Nov 21, 2006
1 parent 6d55f05 commit 9954f77
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions gitweb/gitweb.perl
Original file line number Diff line number Diff line change
Expand Up @@ -3429,6 +3429,7 @@ sub git_log {
}

sub git_commit {
$hash ||= $hash_base || "HEAD";
my %co = parse_commit($hash);
if (!%co) {
die_error(undef, "Unknown commit object");
Expand Down Expand Up @@ -3706,6 +3707,7 @@ sub git_blobdiff_plain {

sub git_commitdiff {
my $format = shift || 'html';
$hash ||= $hash_base || "HEAD";
my %co = parse_commit($hash);
if (!%co) {
die_error(undef, "Unknown commit object");
Expand Down

0 comments on commit 9954f77

Please sign in to comment.