Skip to content

Commit

Permalink
wt-status: don't flush before running "submodule status"
Browse files Browse the repository at this point in the history
This is a holdover from the original implementation in
ac8d5af (builtin-status: submodule summary support,
2008-04-12), which just had the sub-process output to our
descriptor; we had to make sure we had flushed any data that
we produced before it started writing.

Since 3ba7407 (submodule summary: ignore --for-status
option, 2013-09-06), however, we pipe the sub-process output
back to ourselves. So there's no longer any need to flush
(it does not hurt, but it may leave readers wondering why we
do it).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jeff King authored and Junio C Hamano committed Mar 22, 2015
1 parent bb85775 commit 9a9592f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion wt-status.c
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,6 @@ static void wt_status_print_submodule_summary(struct wt_status *s, int uncommitt

sm_summary.git_cmd = 1;
sm_summary.no_stdin = 1;
fflush(s->fp);
sm_summary.out = -1;

run_command(&sm_summary);
Expand Down

0 comments on commit 9a9592f

Please sign in to comment.