Skip to content

Commit

Permalink
Merge branch 'jc/conf-var-doc'
Browse files Browse the repository at this point in the history
Longstanding configuration variable naming rules has been added to
the documentation.

* jc/conf-var-doc:
  CodingGuidelines: describe naming rules for configuration variables
  config.txt: mark deprecated variables more prominently
  config.txt: clarify that add.ignore-errors is deprecated
  • Loading branch information
Junio C Hamano committed Feb 22, 2015
2 parents 744ea70 + 35840a3 commit 9a9c1f1
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 8 deletions.
23 changes: 23 additions & 0 deletions Documentation/CodingGuidelines
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,29 @@ Error Messages
- Say what the error is first ("cannot open %s", not "%s: cannot open")


Externally Visible Names

- For configuration variable names, follow the existing convention:

. The section name indicates the affected subsystem.

. The subsection name, if any, indicates which of an unbounded set
of things to set the value for.

. The variable name describes the effect of tweaking this knob.

The section and variable names that consist of multiple words are
formed by concatenating the words without punctuations (e.g. `-`),
and are broken using bumpyCaps in documentation as a hint to the
reader.

When choosing the variable namespace, do not use variable name for
specifying possibly unbounded set of things, most notably anything
an end user can freely come up with (e.g. branch names). Instead,
use subsection names or variable values, like the existing variable
branch.<name>.description does.


Writing Documentation:

Most (if not all) of the documentation pages are written in the
Expand Down
15 changes: 7 additions & 8 deletions Documentation/config.txt
Original file line number Diff line number Diff line change
Expand Up @@ -683,14 +683,13 @@ core.abbrev::
for abbreviated object names to stay unique for sufficiently long
time.

add.ignore-errors::
add.ignoreErrors::
add.ignore-errors (deprecated)::
Tells 'git add' to continue adding files when some files cannot be
added due to indexing errors. Equivalent to the '--ignore-errors'
option of linkgit:git-add[1]. Older versions of Git accept only
`add.ignore-errors`, which does not follow the usual naming
convention for configuration variables. Newer versions of Git
honor `add.ignoreErrors` as well.
option of linkgit:git-add[1]. `add.ignore-errors` is deprecated,
as it does not follow the usual naming convention for configuration
variables.

alias.*::
Command aliases for the linkgit:git[1] command wrapper - e.g.
Expand Down Expand Up @@ -1960,7 +1959,7 @@ pack.useBitmaps::
true. You should not generally need to turn this off unless
you are debugging pack bitmaps.

pack.writebitmaps::
pack.writebitmaps (deprecated)::
This is a deprecated synonym for `repack.writeBitmaps`.

pack.writeBitmapHashCache::
Expand Down Expand Up @@ -2306,7 +2305,7 @@ sendemail.smtpencryption::
See linkgit:git-send-email[1] for description. Note that this
setting is not subject to the 'identity' mechanism.

sendemail.smtpssl::
sendemail.smtpssl (deprecated)::
Deprecated alias for 'sendemail.smtpencryption = ssl'.

sendemail.smtpsslcertpath::
Expand Down Expand Up @@ -2346,7 +2345,7 @@ sendemail.validate::
sendemail.xmailer::
See linkgit:git-send-email[1] for description.

sendemail.signedoffcc::
sendemail.signedoffcc (deprecated)::
Deprecated alias for 'sendemail.signedoffbycc'.

showbranch.default::
Expand Down

0 comments on commit 9a9c1f1

Please sign in to comment.