Skip to content

Commit

Permalink
Allow use of []-wrapped addresses in git://
Browse files Browse the repository at this point in the history
Allow using "["<host>"]":<port> and "["<host>"]" notations in git://
host addresses. This is needed to be able to connect to addresses
that contain ':' (e.g. numeric IPv6 addresses). Also send the host
header []-wrapped so it can actually be parsed by remote end.

Signed-off-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Ilari Liusvaara authored and Junio C Hamano committed Jan 26, 2010
1 parent e8dbd76 commit 9aa5053
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions connect.c
Original file line number Diff line number Diff line change
Expand Up @@ -523,12 +523,18 @@ struct child_process *git_connect(int fd[2], const char *url_orig,
c = ':';
}

/*
* Don't do destructive transforms with git:// as that
* protocol code does '[]' dewrapping of its own.
*/
if (host[0] == '[') {
end = strchr(host + 1, ']');
if (end) {
*end = 0;
if (protocol != PROTO_GIT) {
*end = 0;
host++;
}
end++;
host++;
} else
end = host;
} else
Expand Down

0 comments on commit 9aa5053

Please sign in to comment.