Skip to content

Commit

Permalink
Move diff.renamelimit out of default configuration.
Browse files Browse the repository at this point in the history
Otherwise we would end up linking all the unneeded stuff into git-daemon
only to link with git_default_config.

Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Junio C Hamano committed Nov 22, 2005
1 parent 07f9247 commit 9ce392f
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 9 deletions.
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,8 @@ deb: dist
### Cleaning rules

clean:
rm -f *.o mozilla-sha1/*.o arm/*.o ppc/*.o compat/*.o git $(PROGRAMS) $(LIB_FILE)
rm -f *.o mozilla-sha1/*.o arm/*.o ppc/*.o compat/*.o $(LIB_FILE)
rm -f $(PROGRAMS) $(SIMPLE_PROGRAMS) git$X
rm -f $(filter-out gitk,$(SCRIPTS))
rm -f *.spec *.pyc *.pyo
rm -rf $(GIT_TARNAME)
Expand Down
5 changes: 0 additions & 5 deletions config.c
Original file line number Diff line number Diff line change
Expand Up @@ -236,11 +236,6 @@ int git_default_config(const char *var, const char *value)
return 0;
}

if (!strcmp(var, "diff.renamelimit")) {
diff_rename_limit_default = git_config_int(var, value);
return 0;
}

/* Add other config variables here.. */
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion diff-files.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ int main(int argc, const char **argv)
const char *prefix = setup_git_directory();
int entries, i;

git_config(git_default_config);
git_config(git_diff_config);
diff_setup(&diff_options);
while (1 < argc && argv[1][0] == '-') {
if (!strcmp(argv[1], "--")) {
Expand Down
2 changes: 1 addition & 1 deletion diff-index.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ int main(int argc, const char **argv)
int allow_options = 1;
int i;

git_config(git_default_config);
git_config(git_diff_config);
diff_setup(&diff_options);
for (i = 1; i < argc; i++) {
const char *arg = argv[i];
Expand Down
3 changes: 3 additions & 0 deletions diff-stages.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ int main(int ac, const char **av)
{
int stage1, stage2;

setup_git_directory();

git_config(git_diff_config);
read_cache();
diff_setup(&diff_options);
while (1 < ac && av[1][0] == '-') {
Expand Down
2 changes: 1 addition & 1 deletion diff-tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ int main(int argc, const char **argv)
unsigned char sha1[2][20];
const char *prefix = setup_git_directory();

git_config(git_default_config);
git_config(git_diff_config);
nr_sha1 = 0;
diff_setup(&diff_options);

Expand Down
10 changes: 10 additions & 0 deletions diff.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,16 @@ static int use_size_cache;

int diff_rename_limit_default = -1;

int git_diff_config(const char *var, const char *value)
{
if (!strcmp(var, "diff.renamelimit")) {
diff_rename_limit_default = git_config_int(var, value);
return 0;
}

return git_default_config(var, value);
}

static char *quote_one(const char *str)
{
int needlen;
Expand Down
1 change: 1 addition & 0 deletions diff.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ extern int diff_scoreopt_parse(const char *opt);
#define DIFF_SETUP_USE_CACHE 2
#define DIFF_SETUP_USE_SIZE_CACHE 4

extern int git_diff_config(const char *var, const char *value);
extern void diff_setup(struct diff_options *);
extern int diff_opt_parse(struct diff_options *, const char **, int);
extern int diff_setup_done(struct diff_options *);
Expand Down

0 comments on commit 9ce392f

Please sign in to comment.