Skip to content

Commit

Permalink
Merge branch 'db/maint-missing-origin'
Browse files Browse the repository at this point in the history
* db/maint-missing-origin:
  Remove total confusion from git-fetch and git-push
  Give error when no remote is configured
  • Loading branch information
Junio C Hamano committed Mar 18, 2009
2 parents 6e5660a + 9326d49 commit 9d5b05c
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 8 deletions.
6 changes: 3 additions & 3 deletions builtin-fetch.c
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,9 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)
else
remote = remote_get(argv[0]);

if (!remote)
die("Where do you want to fetch from today?");

transport = transport_get(remote, remote->url[0]);
if (verbosity >= 2)
transport->verbose = 1;
Expand All @@ -648,9 +651,6 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)
if (depth)
set_option(TRANS_OPT_DEPTH, depth);

if (!transport->url)
die("Where do you want to fetch from today?");

if (argc > 1) {
int j = 0;
refs = xcalloc(argc + 1, sizeof(const char *));
Expand Down
7 changes: 5 additions & 2 deletions builtin-push.c
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,11 @@ static int do_push(const char *repo, int flags)
int i, errs;
struct remote *remote = remote_get(repo);

if (!remote)
die("bad repository '%s'", repo);
if (!remote) {
if (repo)
die("bad repository '%s'", repo);
die("No destination configured to push to.");
}

if (remote->mirror)
flags |= (TRANSPORT_PUSH_MIRROR|TRANSPORT_PUSH_FORCE);
Expand Down
15 changes: 12 additions & 3 deletions remote.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ static int branches_nr;

static struct branch *current_branch;
static const char *default_remote_name;
static int explicit_default_remote_name;

static struct rewrite **rewrite;
static int rewrite_alloc;
Expand Down Expand Up @@ -331,8 +332,10 @@ static int handle_config(const char *key, const char *value, void *cb)
if (!value)
return config_error_nonbool(key);
branch->remote_name = xstrdup(value);
if (branch == current_branch)
if (branch == current_branch) {
default_remote_name = branch->remote_name;
explicit_default_remote_name = 1;
}
} else if (!strcmp(subkey, ".merge")) {
if (!value)
return config_error_nonbool(key);
Expand Down Expand Up @@ -644,18 +647,24 @@ static int valid_remote_nick(const char *name)
struct remote *remote_get(const char *name)
{
struct remote *ret;
int name_given = 0;

read_config();
if (!name)
if (name)
name_given = 1;
else {
name = default_remote_name;
name_given = explicit_default_remote_name;
}

ret = make_remote(name, 0);
if (valid_remote_nick(name)) {
if (!ret->url)
read_remotes_file(ret);
if (!ret->url)
read_branches_file(ret);
}
if (!ret->url)
if (name_given && !ret->url)
add_url_alias(ret, name);
if (!ret->url)
return NULL;
Expand Down

0 comments on commit 9d5b05c

Please sign in to comment.