Skip to content

Commit

Permalink
vcs-svn: a void function shouldn't try to return something
Browse files Browse the repository at this point in the history
As v1.7.4-rc0~184 (2010-10-04) and C99 §6.8.6.4.1 remind us, standard
C does not permit returning an expression of type void, even for a
tail call.

Noticed with gcc -pedantic:

 vcs-svn/svndump.c: In function 'handle_node':
 vcs-svn/svndump.c:213:3: warning: ISO C forbids 'return' with expression,
  in function returning void [-pedantic]

[jn: with simplified log message]

Signed-off-by: Michael Witten <mfwitten@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
  • Loading branch information
Michael Witten authored and Jonathan Nieder committed Mar 29, 2011
1 parent 4c502d6 commit 9e11398
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion vcs-svn/svndump.c
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,8 @@ static void handle_node(void)
if (have_text || have_props || node_ctx.srcRev)
die("invalid dump: deletion node has "
"copyfrom info, text, or properties");
return repo_delete(node_ctx.dst);
repo_delete(node_ctx.dst);
return;
}
if (node_ctx.action == NODEACT_REPLACE) {
repo_delete(node_ctx.dst);
Expand Down

0 comments on commit 9e11398

Please sign in to comment.