Skip to content

Commit

Permalink
remote.c: introduce branch.<name>.pushremote
Browse files Browse the repository at this point in the history
This new configuration variable overrides `remote.pushdefault` and
`branch.<name>.remote` for pushes.  When you pull from one
place (e.g. your upstream) and push to another place (e.g. your own
publishing repository), you would want to set `remote.pushdefault` to
specify the remote to push to for all branches, and use this option to
override it for a specific branch.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Ramkumar Ramachandra authored and Junio C Hamano committed Apr 2, 2013
1 parent 224c217 commit 9f765ce
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 4 deletions.
19 changes: 15 additions & 4 deletions Documentation/config.txt
Original file line number Diff line number Diff line change
Expand Up @@ -730,9 +730,19 @@ branch.<name>.remote::
When on branch <name>, it tells 'git fetch' and 'git push'
which remote to fetch from/push to. The remote to push to
may be overridden with `remote.pushdefault` (for all branches).
If no remote is configured, or if you are not on any branch,
it defaults to `origin` for fetching and `remote.pushdefault`
for pushing.
The remote to push to, for the current branch, may be further
overridden by `branch.<name>.pushremote`. If no remote is
configured, or if you are not on any branch, it defaults to
`origin` for fetching and `remote.pushdefault` for pushing.

branch.<name>.pushremote::
When on branch <name>, it overrides `branch.<name>.remote` for
pushing. It also overrides `remote.pushdefault` for pushing
from branch <name>. When you pull from one place (e.g. your
upstream) and push to another place (e.g. your own publishing
repository), you would want to set `remote.pushdefault` to
specify the remote to push to for all branches, and use this
option to override it for a specific branch.

branch.<name>.merge::
Defines, together with branch.<name>.remote, the upstream branch
Expand Down Expand Up @@ -1903,7 +1913,8 @@ receive.updateserverinfo::

remote.pushdefault::
The remote to push to by default. Overrides
`branch.<name>.remote` for all branches.
`branch.<name>.remote` for all branches, and is overridden by
`branch.<name>.pushremote` for specific branches.

remote.<name>.url::
The URL of a remote repository. See linkgit:git-fetch[1] or
Expand Down
4 changes: 4 additions & 0 deletions remote.c
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,10 @@ static int handle_config(const char *key, const char *value, void *cb)
default_remote_name = branch->remote_name;
explicit_default_remote_name = 1;
}
} else if (!strcmp(subkey, ".pushremote")) {
if (branch == current_branch)
if (git_config_string(&pushremote_name, key, value))
return -1;
} else if (!strcmp(subkey, ".merge")) {
if (!value)
return config_error_nonbool(key);
Expand Down
15 changes: 15 additions & 0 deletions t/t5516-fetch-push.sh
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,21 @@ test_expect_success 'push with config remote.*.pushurl' '
check_push_result testrepo $the_commit heads/master
'

test_expect_success 'push with config branch.*.pushremote' '
mk_test up_repo heads/master &&
mk_test side_repo heads/master &&
mk_test down_repo heads/master &&
test_config remote.up.url up_repo &&
test_config remote.pushdefault side_repo &&
test_config remote.down.url down_repo &&
test_config branch.master.remote up &&
test_config branch.master.pushremote down &&
git push &&
check_push_result up_repo $the_first_commit heads/master &&
check_push_result side_repo $the_first_commit heads/master &&
check_push_result down_repo $the_commit heads/master
'

test_expect_success 'push with dry-run' '
mk_test testrepo heads/master &&
Expand Down

0 comments on commit 9f765ce

Please sign in to comment.