Skip to content

Commit

Permalink
git-remote-mediawiki: don't include HTTP login/password in author
Browse files Browse the repository at this point in the history
On the MediaWiki side, the author information is just the MediaWiki login
of the contributor. The import turns it into login@$wiki_name to create
the author's email address on the wiki side. But we don't want this to
include the HTTP password if it's present in the URL ...

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Matthieu Moy authored and Junio C Hamano committed Oct 20, 2011
1 parent 1d6abac commit 9fb7950
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions contrib/mw-to-git/git-remote-mediawiki
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,10 @@ $dumb_push = ($dumb_push eq "true");

my $wiki_name = $url;
$wiki_name =~ s/[^\/]*:\/\///;
# If URL is like http://user:password@example.com/, we clearly don't
# want the password in $wiki_name. While we're there, also remove user
# and '@' sign, to avoid author like MWUser@HTTPUser@host.com
$wiki_name =~ s/^.*@//;

# Commands parser
my $entry;
Expand Down

0 comments on commit 9fb7950

Please sign in to comment.