Skip to content

Commit

Permalink
git-web--browse: do not start the browser with nohup
Browse files Browse the repository at this point in the history
There is no good reason to run GUI browsers using "nohup". It does not
solve any real problem but creates annoying "nohup.out" files in every
directory where git help -w is run.

Signed-off-by: Dmitry Potapov <dpotapov@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Dmitry Potapov authored and Junio C Hamano committed Feb 10, 2008
1 parent 2e0c290 commit a0685a4
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions git-web--browse.sh
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ case "$browser" in
vers=$(expr "$($browser_path -version)" : '.* \([0-9][0-9]*\)\..*')
NEWTAB='-new-tab'
test "$vers" -lt 2 && NEWTAB=''
nohup "$browser_path" $NEWTAB "$@" &
"$browser_path" $NEWTAB "$@" &
;;
konqueror)
case "$(basename "$browser_path")" in
Expand All @@ -143,14 +143,14 @@ case "$browser" in
eval "$browser_path" newTab "$@"
;;
*)
nohup "$browser_path" "$@" &
"$browser_path" "$@" &
;;
esac
;;
w3m|links|lynx)
eval "$browser_path" "$@"
;;
dillo)
nohup "$browser_path" "$@" &
"$browser_path" "$@" &
;;
esac

0 comments on commit a0685a4

Please sign in to comment.