Skip to content

Commit

Permalink
bisect: report bad rev better
Browse files Browse the repository at this point in the history
The previous one overwrote the variable used to report the bad input
when the input is actually bad, and we did not give a useful enough
information.  This corrects it.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Christian Couder authored and Junio C Hamano committed Apr 12, 2008
1 parent e338907 commit a179a30
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions git-bisect.sh
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,9 @@ bisect_state() {
shift
for rev in "$@"
do
rev=$(git rev-parse --verify "$rev^{commit}") ||
sha=$(git rev-parse --verify "$rev^{commit}") ||
die "Bad rev input: $rev"
bisect_write "$state" "$rev"
bisect_write "$state" "$sha"
done ;;
*,bad)
die "'git bisect bad' can take only one argument." ;;
Expand Down

0 comments on commit a179a30

Please sign in to comment.