Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Merge branch 'jk/filter-branch-no-index'
A recent optimization to filter-branch in v2.7.0 introduced a
regression when --prune-empty filter is used, which has been
corrected.

* jk/filter-branch-no-index:
  filter-branch: resolve $commit^{tree} in no-index case
  • Loading branch information
Junio C Hamano committed Jan 29, 2016
2 parents d10e2cb + 1dc413e commit a2ec948
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion git-filter-branch.sh
Expand Up @@ -404,7 +404,7 @@ while read commit parents; do
then
tree=$(git write-tree)
else
tree="$commit^{tree}"
tree=$(git rev-parse "$commit^{tree}")
fi
workdir=$workdir @SHELL_PATH@ -c "$filter_commit" "git commit-tree" \
"$tree" $parentstr < ../message > ../map/$commit ||
Expand Down
8 changes: 8 additions & 0 deletions t/t7003-filter-branch.sh
Expand Up @@ -333,6 +333,14 @@ test_expect_success 'prune empty collapsed merges' '
test_cmp expect actual
'

test_expect_success 'prune empty works even without index/tree filters' '
git rev-list HEAD >expect &&
git commit --allow-empty -m empty &&
git filter-branch -f --prune-empty HEAD &&
git rev-list HEAD >actual &&
test_cmp expect actual
'

test_expect_success '--remap-to-ancestor with filename filters' '
git checkout master &&
git reset --hard A &&
Expand Down

0 comments on commit a2ec948

Please sign in to comment.