Skip to content

Commit

Permalink
tests: turn off git-daemon tests if FIFOs are not available
Browse files Browse the repository at this point in the history
The Git daemon tests create a FIFO first thing and will hang if said
FIFO is not available.

This is a problem with Git for Windows, where `mkfifo` is an MSYS2
program that leverages MSYS2's POSIX emulation layer, but
`git-daemon.exe` is a MINGW program that has not the first clue about
that POSIX emulation layer and therefore blinks twice when it sees
MSYS2's emulated FIFOs and then just stares into space.

This lets t5570-git-daemon.sh and t5811-proto-disable-git.sh pass.

Signed-off-by: Stepan Kasal <kasal@ucw.cz>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Johannes Schindelin authored and Junio C Hamano committed Jan 28, 2016
1 parent a1f3296 commit a390d7e
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions t/lib-git-daemon.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ then
test_done
fi

if test_have_prereq !PIPE
then
test_skip_or_die $GIT_TEST_GIT_DAEMON "file system does not support FIFOs"
fi

LIB_GIT_DAEMON_PORT=${LIB_GIT_DAEMON_PORT-${this_test#t}}

GIT_DAEMON_PID=
Expand Down

0 comments on commit a390d7e

Please sign in to comment.