Skip to content

Commit

Permalink
Preparation to call determine_author_info from prepare_to_commit
Browse files Browse the repository at this point in the history
Reorder functions definitions such that determine_author_info is
defined before prepare_to_commit. No code changes.

Signed-off-by: Santi Béjar <sbejar@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Santi Béjar authored and Junio C Hamano committed May 6, 2008
1 parent 867fa20 commit a45d46b
Showing 1 changed file with 39 additions and 39 deletions.
78 changes: 39 additions & 39 deletions builtin-commit.c
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,45 @@ static int is_a_merge(const unsigned char *sha1)

static const char sign_off_header[] = "Signed-off-by: ";

static void determine_author_info(struct strbuf *sb)
{
char *name, *email, *date;

name = getenv("GIT_AUTHOR_NAME");
email = getenv("GIT_AUTHOR_EMAIL");
date = getenv("GIT_AUTHOR_DATE");

if (use_message) {
const char *a, *lb, *rb, *eol;

a = strstr(use_message_buffer, "\nauthor ");
if (!a)
die("invalid commit: %s", use_message);

lb = strstr(a + 8, " <");
rb = strstr(a + 8, "> ");
eol = strchr(a + 8, '\n');
if (!lb || !rb || !eol)
die("invalid commit: %s", use_message);

name = xstrndup(a + 8, lb - (a + 8));
email = xstrndup(lb + 2, rb - (lb + 2));
date = xstrndup(rb + 2, eol - (rb + 2));
}

if (force_author) {
const char *lb = strstr(force_author, " <");
const char *rb = strchr(force_author, '>');

if (!lb || !rb)
die("malformed --author parameter");
name = xstrndup(force_author, lb - force_author);
email = xstrndup(lb + 2, rb - (lb + 2));
}

strbuf_addf(sb, "author %s\n", fmt_ident(name, email, date, IDENT_ERROR_ON_NO_NAME));
}

static int prepare_to_commit(const char *index_file, const char *prefix)
{
struct stat statbuf;
Expand Down Expand Up @@ -622,45 +661,6 @@ static int message_is_empty(struct strbuf *sb, int start)
return 1;
}

static void determine_author_info(struct strbuf *sb)
{
char *name, *email, *date;

name = getenv("GIT_AUTHOR_NAME");
email = getenv("GIT_AUTHOR_EMAIL");
date = getenv("GIT_AUTHOR_DATE");

if (use_message) {
const char *a, *lb, *rb, *eol;

a = strstr(use_message_buffer, "\nauthor ");
if (!a)
die("invalid commit: %s", use_message);

lb = strstr(a + 8, " <");
rb = strstr(a + 8, "> ");
eol = strchr(a + 8, '\n');
if (!lb || !rb || !eol)
die("invalid commit: %s", use_message);

name = xstrndup(a + 8, lb - (a + 8));
email = xstrndup(lb + 2, rb - (lb + 2));
date = xstrndup(rb + 2, eol - (rb + 2));
}

if (force_author) {
const char *lb = strstr(force_author, " <");
const char *rb = strchr(force_author, '>');

if (!lb || !rb)
die("malformed --author parameter");
name = xstrndup(force_author, lb - force_author);
email = xstrndup(lb + 2, rb - (lb + 2));
}

strbuf_addf(sb, "author %s\n", fmt_ident(name, email, date, IDENT_ERROR_ON_NO_NAME));
}

static int parse_and_validate_options(int argc, const char *argv[],
const char * const usage[])
{
Expand Down

0 comments on commit a45d46b

Please sign in to comment.