Skip to content

Commit

Permalink
Make section_name_match start on '[', and return the length on success
Browse files Browse the repository at this point in the history
Signed-off-by: Alex Vandiver <alex@chmrr.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Alex Vandiver authored and Junio C Hamano committed Jul 25, 2009
1 parent 735c674 commit a4c0d46
Showing 1 changed file with 16 additions and 3 deletions.
19 changes: 16 additions & 3 deletions config.c
Original file line number Diff line number Diff line change
Expand Up @@ -1174,7 +1174,9 @@ int git_config_set_multivar(const char *key, const char *value,
static int section_name_match (const char *buf, const char *name)
{
int i = 0, j = 0, dot = 0;
for (; buf[i] && buf[i] != ']'; i++) {
if (buf[i] != '[')
return 0;
for (i = 1; buf[i] && buf[i] != ']'; i++) {
if (!dot && isspace(buf[i])) {
dot = 1;
if (name[j++] != '.')
Expand All @@ -1195,7 +1197,17 @@ static int section_name_match (const char *buf, const char *name)
if (buf[i] != name[j++])
break;
}
return (buf[i] == ']' && name[j] == 0);
if (buf[i] == ']' && name[j] == 0) {
/*
* We match, now just find the right length offset by
* gobbling up any whitespace after it, as well
*/
i++;
for (; buf[i] && isspace(buf[i]); i++)
; /* do nothing */
return i;
}
return 0;
}

/* if new_name == NULL, the section is removed instead */
Expand Down Expand Up @@ -1229,7 +1241,8 @@ int git_config_rename_section(const char *old_name, const char *new_name)
; /* do nothing */
if (buf[i] == '[') {
/* it's a section */
if (section_name_match (&buf[i+1], old_name)) {
int offset = section_name_match(&buf[i], old_name);
if (offset > 0) {
ret++;
if (new_name == NULL) {
remove = 1;
Expand Down

0 comments on commit a4c0d46

Please sign in to comment.