Skip to content

Commit

Permalink
Don't make len(p4Cmd("p4 changes -m 1 //foo/...")) == 0 succeed when …
Browse files Browse the repository at this point in the history
…the p4 command itself failed.

When the p4 command failed write out the exit code in the returned dict.

Signed-off-by: Simon Hausmann <shausman@trolltech.com>
  • Loading branch information
Simon Hausmann committed May 23, 2007
1 parent 0c66a78 commit a6d5da3
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion contrib/fast-import/git-p4
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ def p4CmdList(cmd):
result.append(entry)
except EOFError:
pass
pipe.close()
exitCode = pipe.close()
if exitCode != None:
result["p4ExitCode"] = exitCode

return result

Expand Down

0 comments on commit a6d5da3

Please sign in to comment.