Skip to content

Commit

Permalink
Clarify SubmittingPatches Checklist
Browse files Browse the repository at this point in the history
Separate things to be checked when making commits, and things
to be checked when sending patches.

Signed-off-by: Jari Aalto <jari.aalto@cante.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Jari Aalto authored and Junio C Hamano committed Apr 30, 2007
1 parent b3cb7e4 commit a7af09d
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion Documentation/SubmittingPatches
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
Checklist (and a short version for the impatient):

Commits:

- make commits of logical units
- check for unnecessary whitespace with "git diff --check"
before committing
Expand All @@ -12,8 +14,14 @@ Checklist (and a short version for the impatient):
commit message (or just use the option "-s" when
committing) to confirm that you agree to the Developer's
Certificate of Origin
- do not PGP sign your patch

Patch:

- use "git format-patch -M" to create the patch
- send your patch to <git@vger.kernel.org>. If you use
git-send-email(1), please test it first by sending
email to yourself.
- do not PGP sign your patch
- do not attach your patch, but read in the mail
body, unless you cannot teach your mailer to
leave the formatting of the patch alone.
Expand Down

0 comments on commit a7af09d

Please sign in to comment.