Skip to content

Commit

Permalink
remote-bzr: support the new 'force' option
Browse files Browse the repository at this point in the history
Signed-off-by: Richard Hansen <rhansen@bbn.com>
Acked-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Richard Hansen authored and Junio C Hamano committed Feb 24, 2014
1 parent fdec195 commit a7cb127
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 2 deletions.
31 changes: 30 additions & 1 deletion contrib/remote-helpers/git-remote-bzr
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,8 @@ def do_export(parser):
peer = bzrlib.branch.Branch.open(peers[name],
possible_transports=transports)
try:
peer.bzrdir.push_branch(branch, revision_id=revid)
peer.bzrdir.push_branch(branch, revision_id=revid,
overwrite=force)
except bzrlib.errors.DivergedBranches:
print "error %s non-fast forward" % ref
continue
Expand Down Expand Up @@ -719,8 +720,32 @@ def do_capabilities(parser):
print "*import-marks %s" % path
print "*export-marks %s" % path

print "option"
print

class InvalidOptionValue(Exception):
pass

def get_bool_option(val):
if val == 'true':
return True
elif val == 'false':
return False
else:
raise InvalidOptionValue()

def do_option(parser):
global force
opt, val = parser[1:3]
try:
if opt == 'force':
force = get_bool_option(val)
print 'ok'
else:
print 'unsupported'
except InvalidOptionValue:
print "error '%s' is not a valid value for option '%s'" % (val, opt)

def ref_is_valid(name):
return not True in [c in name for c in '~^: \\']

Expand Down Expand Up @@ -883,6 +908,7 @@ def main(args):
global is_tmp
global branches, peers
global transports
global force

alias = args[1]
url = args[2]
Expand All @@ -896,6 +922,7 @@ def main(args):
branches = {}
peers = {}
transports = []
force = False

if alias[5:] == url:
is_tmp = True
Expand Down Expand Up @@ -931,6 +958,8 @@ def main(args):
do_import(parser)
elif parser.check('export'):
do_export(parser)
elif parser.check('option'):
do_option(parser)
else:
die('unhandled command: %s' % line)
sys.stdout.flush()
Expand Down
22 changes: 21 additions & 1 deletion contrib/remote-helpers/test-bzr.sh
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,33 @@ test_expect_success 'pushing' '
test_cmp expected actual
'

test_expect_success 'forced pushing' '
(
cd gitrepo &&
echo three-new >content &&
git commit -a --amend -m three-new &&
git push -f
) &&
(
cd bzrrepo &&
# the forced update overwrites the bzr branch but not the bzr
# working directory (it tries to merge instead)
bzr revert
) &&
echo three-new >expected &&
cat bzrrepo/content >actual &&
test_cmp expected actual
'

test_expect_success 'roundtrip' '
(
cd gitrepo &&
git pull &&
git log --format="%s" -1 origin/master >actual
) &&
echo three >expected &&
echo three-new >expected &&
test_cmp expected actual &&
(cd gitrepo && git push && git pull) &&
Expand Down

0 comments on commit a7cb127

Please sign in to comment.