Skip to content

Commit

Permalink
get_urlmatch: avoid useless strbuf write
Browse files Browse the repository at this point in the history
We create a strbuf only to insert a single string, pass the
resulting buffer to a function (which does not modify the
string), and then free it. We can just pass the original
string instead.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jeff King authored and Junio C Hamano committed Aug 20, 2015
1 parent f225987 commit a92330d
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions builtin/config.c
Original file line number Diff line number Diff line change
Expand Up @@ -425,14 +425,11 @@ static int get_urlmatch(const char *var, const char *url)

for_each_string_list_item(item, &values) {
struct urlmatch_current_candidate_value *matched = item->util;
struct strbuf key = STRBUF_INIT;
struct strbuf buf = STRBUF_INIT;

strbuf_addstr(&key, item->string);
format_config(&buf, key.buf,
format_config(&buf, item->string,
matched->value_is_null ? NULL : matched->value.buf);
fwrite(buf.buf, 1, buf.len, stdout);
strbuf_release(&key);
strbuf_release(&buf);

strbuf_release(&matched->value);
Expand Down

0 comments on commit a92330d

Please sign in to comment.