Skip to content

Commit

Permalink
Don't dereference a strdup-returned NULL
Browse files Browse the repository at this point in the history
There are only a dozen or so uses of strdup in all of git.
Of those, most seem ok, but this one isn't:

Signed-off-by: Jim Meyering <jim@meyering.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jim Meyering authored and Junio C Hamano committed Jun 13, 2007
1 parent c43f64a commit aa32eed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion remote.c
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ int match_refs(struct ref *src, struct ref *dst, struct ref ***dst_tail,
strcpy(dst_name, pat->dst);
strcat(dst_name, src->name + strlen(pat->src));
} else
dst_name = strdup(src->name);
dst_name = xstrdup(src->name);
dst_peer = find_ref_by_name(dst, dst_name);
if (dst_peer && dst_peer->peer_ref)
/* We're already sending something to this ref. */
Expand Down

0 comments on commit aa32eed

Please sign in to comment.