Skip to content

Commit

Permalink
refs.c: make write_ref_sha1 static
Browse files Browse the repository at this point in the history
No external users call write_ref_sha1 any more so let's declare it static.

Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Ronnie Sahlberg authored and Junio C Hamano committed Oct 15, 2014
1 parent cd94f76 commit aae383d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
10 changes: 8 additions & 2 deletions refs.c
Original file line number Diff line number Diff line change
Expand Up @@ -2706,6 +2706,9 @@ static int rename_ref_available(const char *oldname, const char *newname)
return ret;
}

static int write_ref_sha1(struct ref_lock *lock, const unsigned char *sha1,
const char *logmsg);

int rename_ref(const char *oldrefname, const char *newrefname, const char *logmsg)
{
unsigned char sha1[20], orig_sha1[20];
Expand Down Expand Up @@ -2950,8 +2953,11 @@ int is_branch(const char *refname)
return !strcmp(refname, "HEAD") || starts_with(refname, "refs/heads/");
}

/* This function must return a meaningful errno */
int write_ref_sha1(struct ref_lock *lock,
/*
* Write sha1 into the ref specified by the lock. Make sure that errno
* is sane on error.
*/
static int write_ref_sha1(struct ref_lock *lock,
const unsigned char *sha1, const char *logmsg)
{
static char term = '\n';
Expand Down
3 changes: 0 additions & 3 deletions refs.h
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,6 @@ extern int commit_ref(struct ref_lock *lock);
/** Release any lock taken but not written. **/
extern void unlock_ref(struct ref_lock *lock);

/** Writes sha1 into the ref specified by the lock. **/
extern int write_ref_sha1(struct ref_lock *lock, const unsigned char *sha1, const char *msg);

/*
* Setup reflog before using. Set errno to something meaningful on failure.
*/
Expand Down

0 comments on commit aae383d

Please sign in to comment.