Skip to content

Commit

Permalink
Merge branch 'maint' to sync with 1.5.4.4
Browse files Browse the repository at this point in the history
* maint:
  GIT 1.5.4.4
  ident.c: reword error message when the user name cannot be determined
  Fix dcommit, rebase when rewriteRoot is in use
  Really make the LF after reset in fast-import optional
  • Loading branch information
Junio C Hamano committed Mar 9, 2008
2 parents caa9982 + 56d5fe2 commit ad416ed
Show file tree
Hide file tree
Showing 7 changed files with 39 additions and 14 deletions.
32 changes: 26 additions & 6 deletions Documentation/RelNotes-1.5.4.4.txt
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,30 @@ Fixes since v1.5.4.3
* "git revert" did not properly fail when attempting to run with a
dirty index.

Also included are a handful documentation updates.
* "git merge --no-commit --no-ff <other>" incorrectly made commits.

* "git merge --squash --no-ff <other>", which is a nonsense combination
of options, was not rejected.

* "git ls-remote" and "git remote show" against an empty repository
failed, instead of just giving an empty result (regression).

* "git fast-import" did not handle a renamed path whose name needs to be
quoted, due to a bug in unquote_c_style() function.

* "git cvsexportcommit" was confused when multiple files with the same
basename needed to be pushed out in the same commit.

* "git daemon" did not send early errors to syslog.

---
exec >/var/tmp/1
echo O=$(git describe maint)
O=v1.5.4.3-32-g0f2d447
git shortlog --no-merges $O..maint
* "git log --merge" did not work well with --left-right option.

* "git svn" promprted for client cert password every time it accessed the
server.

* The reset command in "git fast-import" data stream was documented to
end with an optional LF, but it actually required one.

* "git svn dcommit/rebase" did not honor --rewrite-root option.

Also included are a handful documentation updates.
4 changes: 0 additions & 4 deletions Documentation/RelNotes-1.5.5.txt
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,9 @@ Fixes since v1.5.4
All of the fixes in v1.5.4 maintenance series are included in
this release, unless otherwise noted.

* "git-daemon" did not send early errors to syslog.

* "git-http-push" did not allow deletion of remote ref with the usual
"push <remote> :<branch>" syntax.

* "git-log --merge" did not well work with --left-right option.

* "git-rebase --abort" did not go back to the right location if
"git-reset" was run during the "git-rebase" session.

Expand Down
3 changes: 2 additions & 1 deletion Documentation/git.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,10 @@ unreleased) version of git, that is available from 'master'
branch of the `git.git` repository.
Documentation for older releases are available here:

* link:v1.5.4.3/git.html[documentation for release 1.5.4.3]
* link:v1.5.4.4/git.html[documentation for release 1.5.4.4]

* release notes for
link:RelNotes-1.5.4.4.txt[1.5.4.4],
link:RelNotes-1.5.4.3.txt[1.5.4.3],
link:RelNotes-1.5.4.2.txt[1.5.4.2],
link:RelNotes-1.5.4.1.txt[1.5.4.1],
Expand Down
3 changes: 2 additions & 1 deletion fast-import.c
Original file line number Diff line number Diff line change
Expand Up @@ -2291,7 +2291,8 @@ static void cmd_reset_branch(void)
else
b = new_branch(sp);
read_next_command();
if (!cmd_from(b) && command_buf.len > 0)
cmd_from(b);
if (command_buf.len > 0)
unread_command_buf = 1;
}

Expand Down
7 changes: 6 additions & 1 deletion git-svn.perl
Original file line number Diff line number Diff line change
Expand Up @@ -1540,9 +1540,14 @@ sub find_by_url { # repos_root and, path are optional
$remotes->{$repo_id}->{$_});
}
my $p = $path;
my $rwr = rewrite_root({repo_id => $repo_id});
unless (defined $p) {
$p = $full_url;
$p =~ s#^\Q$u\E(?:/|$)## or next;
my $z = $u;
if ($rwr) {
$z = $rwr;
}
$p =~ s#^\Q$z\E(?:/|$)## or next;
}
foreach my $f (keys %$fetch) {
next if $f ne $p;
Expand Down
2 changes: 1 addition & 1 deletion ident.c
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ static const char au_env[] = "GIT_AUTHOR_NAME";
static const char co_env[] = "GIT_COMMITTER_NAME";
static const char *env_hint =
"\n"
"*** Your name cannot be determined from your system services (gecos).\n"
"*** Please tell me who you are.\n"
"\n"
"Run\n"
"\n"
Expand Down
2 changes: 2 additions & 0 deletions t/t9300-fast-import.sh
Original file line number Diff line number Diff line change
Expand Up @@ -869,6 +869,8 @@ zcommits
COMMIT
reset refs/tags/O3-2nd
from :5
reset refs/tags/O3-3rd
from :5
INPUT_END

cat >expect <<INPUT_END
Expand Down

0 comments on commit ad416ed

Please sign in to comment.