Skip to content

Commit

Permalink
ident: reword empty ident error message
Browse files Browse the repository at this point in the history
There's on point in printing the name, since it is by
definition the empty string if we have reached this code
path. Instead, let's be more clear that we are complaining
about the empty name, but still show the email address that
it is attached to (since that may provide some context to
the user).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jeff King authored and Junio C Hamano committed May 25, 2012
1 parent a21c2f9 commit b00f6cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ident.c
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ const char *fmt_ident(const char *name, const char *email,
if (error_on_no_name) {
if (name == git_default_name.buf)
fputs(env_hint, stderr);
die("empty ident %s <%s> not allowed", name, email);
die("empty ident name (for <%s>) not allowed", email);
}
pw = xgetpwuid_self();
name = pw->pw_name;
Expand Down

0 comments on commit b00f6cf

Please sign in to comment.