Skip to content

Commit

Permalink
pathspec: drop "lone : means no pathspec" from get_pathspec()
Browse files Browse the repository at this point in the history
We may want to give the pathspec subsystem such a feature, but not while
we are still using get_pathspec() that returns a stupid "char **" that
loses subtle nuances that existed in the input string.

In the meantime, the callers of get_pathspec() that want to support it
could do an equivalent before feeding their argv[] to the function
themselves quite easily.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed May 10, 2011
1 parent 6d94292 commit b060ce7
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,6 @@ const char *prefix_pathspec(const char *prefix, int prefixlen, const char *elt)
}
if (*copyfrom == ')')
copyfrom++;
} else if (!elt[1]) {
/* Just ':' -- no element! */
return NULL;
} else {
/* shorthand */
for (copyfrom = elt + 1;
Expand Down

0 comments on commit b060ce7

Please sign in to comment.