Skip to content

Commit

Permalink
trailer: use CHILD_PROCESS_INIT in apply_command()
Browse files Browse the repository at this point in the history
Initialize the struct child_process variable cp at declaration time.
This is shorter, saves a function call and prevents using the variable
before initialization by mistake.

Suggested-by: Jeff King <peff@peff.net>
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
René Scharfe authored and Junio C Hamano committed Nov 10, 2014
1 parent 66edfe9 commit b226293
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions trailer.c
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ static const char *apply_command(const char *command, const char *arg)
{
struct strbuf cmd = STRBUF_INIT;
struct strbuf buf = STRBUF_INIT;
struct child_process cp;
struct child_process cp = CHILD_PROCESS_INIT;
const char *argv[] = {NULL, NULL};
const char *result;

Expand All @@ -237,7 +237,6 @@ static const char *apply_command(const char *command, const char *arg)
strbuf_replace(&cmd, TRAILER_ARG_STRING, arg);

argv[0] = cmd.buf;
child_process_init(&cp);
cp.argv = argv;
cp.env = local_repo_env;
cp.no_stdin = 1;
Expand Down

0 comments on commit b226293

Please sign in to comment.