Skip to content

Commit

Permalink
ls-tree $di $dir: do not mistakenly recurse into directories
Browse files Browse the repository at this point in the history
When applying two pathspecs, one of which is named as a prefix to the
other, we mistakenly recursed into the shorter one.

Noticed and fixed by David Reis.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Sep 12, 2010
1 parent 9904fad commit b294ed6
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
2 changes: 2 additions & 0 deletions builtin/ls-tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ static int show_recursive(const char *base, int baselen, const char *pathname)
speclen = strlen(spec);
if (speclen <= len)
continue;
if (spec[len] && spec[len] != '/')
continue;
if (memcmp(pathname, spec, len))
continue;
return 1;
Expand Down
9 changes: 9 additions & 0 deletions t/t3100-ls-tree-restrict.sh
Original file line number Diff line number Diff line change
Expand Up @@ -165,4 +165,13 @@ test_expect_success \
EOF
test_output'

test_expect_success \
'ls-tree with one path a prefix of the other' \
'git ls-tree $tree path2/baz path2/bazbo >current &&
make_expected <<\EOF &&
040000 tree X path2/baz
120000 blob X path2/bazbo
EOF
test_output'

test_done

0 comments on commit b294ed6

Please sign in to comment.