Skip to content

Commit

Permalink
refs.c: Write reflogs for notes just like for branch heads
Browse files Browse the repository at this point in the history
The notes code intends to write reflog entries, but currently they are
not written because log_ref_write() checks for the refname path
explicitly.

Add refs/notes to the list of allowed paths so that notes references are
treated just like branch heads, i.e. according to core.logAllRefUpdates
and core.bare.

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
Acked-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Michael J Gruber authored and Junio C Hamano committed Mar 30, 2010
1 parent 4d80fa8 commit b2e256b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions refs.c
Original file line number Diff line number Diff line change
Expand Up @@ -1276,6 +1276,7 @@ static int log_ref_write(const char *ref_name, const unsigned char *old_sha1,
if (log_all_ref_updates &&
(!prefixcmp(ref_name, "refs/heads/") ||
!prefixcmp(ref_name, "refs/remotes/") ||
!prefixcmp(ref_name, "refs/notes/") ||
!strcmp(ref_name, "HEAD"))) {
if (safe_create_leading_directories(log_file) < 0)
return error("unable to create directory for %s",
Expand Down
2 changes: 1 addition & 1 deletion t/t3301-notes.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ cat >expect <<EOF
d423f8c refs/notes/commits@{0}: notes: Notes added by 'git notes add'
EOF

test_expect_failure 'create reflog entry' '
test_expect_success 'create reflog entry' '
git reflog show refs/notes/commits >output &&
test_cmp expect output
'
Expand Down

0 comments on commit b2e256b

Please sign in to comment.