Skip to content

Commit

Permalink
rev-list --count: separate count for --cherry-mark
Browse files Browse the repository at this point in the history
When --count is used with --cherry-mark, omit the patch equivalent
commits from the count for left and right commits and print the count of
equivalent commits separately.

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Michael J Gruber authored and Junio C Hamano committed Apr 26, 2011
1 parent ec014ea commit b388e14
Show file tree
Hide file tree
Showing 4 changed files with 40 additions and 3 deletions.
5 changes: 4 additions & 1 deletion Documentation/rev-list-options.txt
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,10 @@ ifdef::git-rev-list[]
Print a number stating how many commits would have been
listed, and suppress all other output. When used together
with '--left-right', instead print the counts for left and
right commits, separated by a tab.
right commits, separated by a tab. When used together with
'--cherry-mark', omit patch equivalent commits from these
counts and print the count for equivalent commits separated
by a tab.
endif::git-rev-list[]


Expand Down
10 changes: 8 additions & 2 deletions builtin/rev-list.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ static void show_commit(struct commit *commit, void *data)
graph_show_commit(revs->graph);

if (revs->count) {
if (commit->object.flags & SYMMETRIC_LEFT)
if (commit->object.flags & PATCHSAME)
revs->count_same++;
else if (commit->object.flags & SYMMETRIC_LEFT)
revs->count_left++;
else
revs->count_right++;
Expand Down Expand Up @@ -406,8 +408,12 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)
&info);

if (revs.count) {
if (revs.left_right)
if (revs.left_right && revs.cherry_mark)
printf("%d\t%d\t%d\n", revs.count_left, revs.count_right, revs.count_same);
else if (revs.left_right)
printf("%d\t%d\n", revs.count_left, revs.count_right);
else if (revs.cherry_mark)
printf("%d\t%d\n", revs.count_left + revs.count_right, revs.count_same);
else
printf("%d\n", revs.count_left + revs.count_right);
}
Expand Down
1 change: 1 addition & 0 deletions revision.h
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ struct rev_info {
/* commit counts */
int count_left;
int count_right;
int count_same;
};

#define REV_TREE_SAME 0
Expand Down
27 changes: 27 additions & 0 deletions t/t6007-rev-list-cherry-pick-file.sh
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,33 @@ test_expect_success '--cherry' '
test_cmp actual.named expect
'

cat >expect <<EOF
1 1
EOF

test_expect_success '--cherry --count' '
git rev-list --cherry --count F...E -- bar > actual &&
test_cmp actual expect
'

cat >expect <<EOF
2 2
EOF

test_expect_success '--cherry-mark --count' '
git rev-list --cherry-mark --count F...E -- bar > actual &&
test_cmp actual expect
'

cat >expect <<EOF
1 1 2
EOF

test_expect_success '--cherry-mark --left-right --count' '
git rev-list --cherry-mark --left-right --count F...E -- bar > actual &&
test_cmp actual expect
'

test_expect_success '--cherry-pick with independent, but identical branches' '
git symbolic-ref HEAD refs/heads/independent &&
rm .git/index &&
Expand Down

0 comments on commit b388e14

Please sign in to comment.