Skip to content

Commit

Permalink
HTTP cleanup
Browse files Browse the repository at this point in the history
Fix broken build when USE_CURL_MULTI is not defined, as noted by Becky Bruce.

During cleanup, free header slist that was created during init, as noted
by Junio.

Signed-off-by: Nick Hengeveld <nickh@reactrix.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Nick Hengeveld authored and Junio C Hamano committed Jun 6, 2006
1 parent efd0201 commit b3ca4e4
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
8 changes: 8 additions & 0 deletions http-push.c
Original file line number Diff line number Diff line change
Expand Up @@ -788,6 +788,7 @@ static void finish_request(struct transfer_request *request)
}
}

#ifdef USE_CURL_MULTI
void fill_active_slots(void)
{
struct transfer_request *request = request_queue_head;
Expand Down Expand Up @@ -821,6 +822,7 @@ void fill_active_slots(void)
slot = slot->next;
}
}
#endif

static void get_remote_object_list(unsigned char parent);

Expand Down Expand Up @@ -851,8 +853,10 @@ static void add_fetch_request(struct object *obj)
request->next = request_queue_head;
request_queue_head = request;

#ifdef USE_CURL_MULTI
fill_active_slots();
step_active_slots();
#endif
}

static int add_send_request(struct object *obj, struct remote_lock *lock)
Expand Down Expand Up @@ -889,8 +893,10 @@ static int add_send_request(struct object *obj, struct remote_lock *lock)
request->next = request_queue_head;
request_queue_head = request;

#ifdef USE_CURL_MULTI
fill_active_slots();
step_active_slots();
#endif

return 1;
}
Expand Down Expand Up @@ -2523,7 +2529,9 @@ int main(int argc, char **argv)
if (objects_to_send)
fprintf(stderr, " sending %d objects\n",
objects_to_send);
#ifdef USE_CURL_MULTI
fill_active_slots();
#endif
finish_all_active_slots();

/* Update the remote branch if all went well */
Expand Down
7 changes: 6 additions & 1 deletion http.c
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,8 @@ void http_cleanup(void)
curl_multi_cleanup(curlm);
#endif
curl_global_cleanup();


curl_slist_free_all(pragma_header);
}

struct active_request_slot *get_active_slot(void)
Expand Down Expand Up @@ -438,11 +439,15 @@ void release_active_slot(struct active_request_slot *slot)
{
closedown_active_slot(slot);
if (slot->curl) {
#ifdef USE_CURL_MULTI
curl_multi_remove_handle(curlm, slot->curl);
#endif
curl_easy_cleanup(slot->curl);
slot->curl = NULL;
}
#ifdef USE_CURL_MULTI
fill_active_slots();
#endif
}

static void finish_active_slot(struct active_request_slot *slot)
Expand Down

0 comments on commit b3ca4e4

Please sign in to comment.