diff --no-index: do not forget to run diff_setup_done()

Code inspection by Linus found this. Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-mirror · Sep 14, 2007 · b78281f · b78281f
1 parent 8419d2e
commit b78281f
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/diff-lib.c b/diff-lib.c
@@ -298,6 +298,8 @@ int setup_diff_no_index(struct rev_info *revs,
 	revs->diffopt.nr_paths = 2;
 	revs->diffopt.no_index = 1;
 	revs->max_count = -2;
+	if (diff_setup_done(&revs->diffopt) < 0)
+		die("diff_setup_done failed");
 	return 0;
 }