Skip to content

Commit

Permalink
t/gitweb-lib.sh: skip gitweb tests when perl dependencies are not met
Browse files Browse the repository at this point in the history
Linus noticed that we go ahead testing gitweb and fail miserably on a
box with Perl but not perl-CGI library. We already have a code to detect
lack of Perl and refrain from testing gitweb in t/gitweb-lib.sh (by the
way, shouldn't it be called t/lib-gitweb.sh?), so let's extend it
to cover this case as well.

Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Jun 15, 2011
1 parent 2c162b5 commit b7d8780
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions t/gitweb-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -107,4 +107,9 @@ perl -MEncode -e '$e="";decode_utf8($e, Encode::FB_CROAK)' >/dev/null 2>&1 || {
test_done
}

perl -MCGI -MCGI::Util -MCGI::Carp -e 0 >/dev/null 2>&1 || {
skip_all='skipping gitweb tests, CGI module unusable'
test_done
}

gitweb_init

0 comments on commit b7d8780

Please sign in to comment.