Skip to content

Commit

Permalink
Merge branch 'jr/grep-en-config'
Browse files Browse the repository at this point in the history
* jr/grep-en-config:
  grep: allow -E and -n to be turned on by default via configuration
  • Loading branch information
Junio C Hamano committed Apr 2, 2011
2 parents 6c80cd2 + b22520a commit b966427
Show file tree
Hide file tree
Showing 4 changed files with 52 additions and 1 deletion.
6 changes: 6 additions & 0 deletions Documentation/config.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1098,6 +1098,12 @@ All gitcvs variables except for 'gitcvs.usecrlfattr' and
is one of "ext" and "pserver") to make them apply only for the given
access method.

grep.lineNumber::
If set to true, enable '-n' option by default.

grep.extendedRegexp::
If set to true, enable '--extended-regexp' option by default.

gui.commitmsgwidth::
Defines how wide the commit message window is in the
linkgit:git-gui[1]. "75" is the default.
Expand Down
10 changes: 10 additions & 0 deletions Documentation/git-grep.txt
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ Look for specified patterns in the tracked files in the work tree, blobs
registered in the index file, or blobs in given tree objects.


CONFIGURATION
-------------

grep.lineNumber::
If set to true, enable '-n' option by default.

grep.extendedRegexp::
If set to true, enable '--extended-regexp' option by default.


OPTIONS
-------
--cached::
Expand Down
13 changes: 13 additions & 0 deletions builtin/grep.c
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,19 @@ static int grep_config(const char *var, const char *value, void *cb)
default: return 0;
}

if (!strcmp(var, "grep.extendedregexp")) {
if (git_config_bool(var, value))
opt->regflags |= REG_EXTENDED;
else
opt->regflags &= ~REG_EXTENDED;
return 0;
}

if (!strcmp(var, "grep.linenumber")) {
opt->linenum = git_config_bool(var, value);
return 0;
}

if (!strcmp(var, "color.grep"))
opt->color = git_config_colorbool(var, value, -1);
else if (!strcmp(var, "color.grep.context"))
Expand Down
24 changes: 23 additions & 1 deletion t/t7810-grep.sh
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,29 @@ do
echo ${HC}file:4:foo mmap bar_mmap
echo ${HC}file:5:foo_mmap bar mmap baz
} >expected &&
git grep -n -w -e mmap $H >actual &&
git -c grep.linenumber=false grep -n -w -e mmap $H >actual &&
test_cmp expected actual
'

test_expect_success "grep -w $L" '
{
echo ${HC}file:1:foo mmap bar
echo ${HC}file:3:foo_mmap bar mmap
echo ${HC}file:4:foo mmap bar_mmap
echo ${HC}file:5:foo_mmap bar mmap baz
} >expected &&
git -c grep.linenumber=true grep -w -e mmap $H >actual &&
test_cmp expected actual
'

test_expect_success "grep -w $L" '
{
echo ${HC}file:foo mmap bar
echo ${HC}file:foo_mmap bar mmap
echo ${HC}file:foo mmap bar_mmap
echo ${HC}file:foo_mmap bar mmap baz
} >expected &&
git -c grep.linenumber=true grep --no-line-number -w -e mmap $H >actual &&
test_cmp expected actual
'

Expand Down

0 comments on commit b966427

Please sign in to comment.