Skip to content

Commit

Permalink
Drop double-semicolon in C
Browse files Browse the repository at this point in the history
The worst offenders are "continue;;" and "break;;" in switch statements.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Feb 11, 2009
1 parent 057e713 commit ba19a80
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion fast-import.c
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,7 @@ static char *create_index(void)
/* Generate the fan-out array. */
c = idx;
for (i = 0; i < 256; i++) {
struct object_entry **next = c;;
struct object_entry **next = c;
while (next < last) {
if ((*next)->sha1[0] != i)
break;
Expand Down
2 changes: 1 addition & 1 deletion rerere.c
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ static int do_plain_rerere(struct string_list *rr, int fd)
hex = xstrdup(sha1_to_hex(sha1));
string_list_insert(path, rr)->util = hex;
if (mkdir(git_path("rr-cache/%s", hex), 0755))
continue;;
continue;
handle_file(path, NULL, rr_path(hex, "preimage"));
fprintf(stderr, "Recorded preimage for '%s'\n", path);
}
Expand Down
2 changes: 1 addition & 1 deletion tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ int read_tree_recursive(struct tree *tree,
case 0:
continue;
case READ_TREE_RECURSIVE:
break;;
break;
default:
return -1;
}
Expand Down
2 changes: 1 addition & 1 deletion walker.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ void walker_say(struct walker *walker, const char *fmt, const char *hex)
static void report_missing(const struct object *obj)
{
char missing_hex[41];
strcpy(missing_hex, sha1_to_hex(obj->sha1));;
strcpy(missing_hex, sha1_to_hex(obj->sha1));
fprintf(stderr, "Cannot obtain needed %s %s\n",
obj->type ? typename(obj->type): "object", missing_hex);
if (!is_null_sha1(current_commit_sha1))
Expand Down

0 comments on commit ba19a80

Please sign in to comment.