Skip to content

Commit

Permalink
Add --ignore-unmatch option to exit with zero status when no files ar…
Browse files Browse the repository at this point in the history
…e removed.

Signed-off-by: Steven Grimm <koreth@midwinter.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Steven Grimm authored and Junio C Hamano committed Apr 17, 2007
1 parent f948792 commit bb1faf0
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 5 deletions.
5 changes: 4 additions & 1 deletion Documentation/git-rm.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ git-rm - Remove files from the working tree and from the index

SYNOPSIS
--------
'git-rm' [-f] [-n] [-r] [--cached] [--] <file>...
'git-rm' [-f] [-n] [-r] [--cached] [--ignore-unmatch] [--quiet] [--] <file>...

DESCRIPTION
-----------
Expand Down Expand Up @@ -47,6 +47,9 @@ OPTIONS
the paths only from the index, leaving working tree
files.

\--ignore-unmatch::
Exit with a zero status even if no files matched.

\--quiet::
git-rm normally outputs one line (in the form of an "rm" command)
for each file removed. This option suppresses that output.
Expand Down
21 changes: 17 additions & 4 deletions builtin-rm.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "tree-walk.h"

static const char builtin_rm_usage[] =
"git-rm [-f] [-n] [-r] [--cached] [--quiet] [--] <file>...";
"git-rm [-f] [-n] [-r] [--cached] [--ignore-unmatch] [--quiet] [--] <file>...";

static struct {
int nr, alloc;
Expand Down Expand Up @@ -105,6 +105,7 @@ int cmd_rm(int argc, const char **argv, const char *prefix)
{
int i, newfd;
int show_only = 0, force = 0, index_only = 0, recursive = 0, quiet = 0;
int ignore_unmatch = 0;
const char **pathspec;
char *seen;

Expand Down Expand Up @@ -134,6 +135,8 @@ int cmd_rm(int argc, const char **argv, const char *prefix)
recursive = 1;
else if (!strcmp(arg, "--quiet"))
quiet = 1;
else if (!strcmp(arg, "--ignore-unmatch"))
ignore_unmatch = 1;
else
usage(builtin_rm_usage);
}
Expand All @@ -155,14 +158,24 @@ int cmd_rm(int argc, const char **argv, const char *prefix)

if (pathspec) {
const char *match;
int seen_any = 0;
for (i = 0; (match = pathspec[i]) != NULL ; i++) {
if (!seen[i])
die("pathspec '%s' did not match any files",
match);
if (!seen[i]) {
if (!ignore_unmatch) {
die("pathspec '%s' did not match any files",
match);
}
}
else {
seen_any = 1;
}
if (!recursive && seen[i] == MATCHED_RECURSIVELY)
die("not removing '%s' recursively without -r",
*match ? match : ".");
}

if (! seen_any)
exit(0);
}

/*
Expand Down
4 changes: 4 additions & 0 deletions t/t3600-rm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ test_expect_success \
'When the rm in "git-rm -f" fails, it should not remove the file from the index' \
'git-ls-files --error-unmatch baz'

test_expect_success 'Remove nonexistent file with --ignore-unmatch' '
git rm --ignore-unmatch nonexistent
'

test_expect_success '"rm" command printed' '
echo frotz > test-file &&
git add test-file &&
Expand Down

0 comments on commit bb1faf0

Please sign in to comment.